Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MMS test bugfixes and docs #217

Merged
merged 29 commits into from
Jul 30, 2024
Merged

MMS test bugfixes and docs #217

merged 29 commits into from
Jul 30, 2024

Conversation

mrhardman
Copy link
Collaborator

@mrhardman mrhardman commented May 21, 2024

PR to add

In addition, this could be a moment to discuss the best location to store the existing MMS input files - > should they be moved from runs to an examples_mms/ directory? @johnomotani

@mrhardman mrhardman self-assigned this May 21, 2024
@mrhardman
Copy link
Collaborator Author

If I understand correctly, one consideration for the location of the MMS test TOML inputs could be that we might want to test whether the inputs are valid on CI, by running them for 1 timestep, like the TOML in examples/. Currently it looks like many of the MMS test inputs in the runs/ directory have become out of date following the various input namelist changes.

@johnomotani
Copy link
Collaborator

BTW all the documentation builds seem to be broken at the moment - there is some error about a missing get_cmap function when loading PyPlot. I don't think it's anything we've done, and I can't reproduce it on my laptop, so I'm hoping it goes away with some package updates (unless anyone wants to dig into it, e.g. excluding the version of PyPlot that it's currently trying to use so it falls back to the previous one?).

mrhardman added 14 commits May 22, 2024 10:30
…ly differ by retained example by resolution parameters, and can thus be easily regenerated.
…ns) and 1D3V(neutrals) test with a simple sheath model for electrons.
…r a 2D2V/2D3V simulation with Boltzmann electrons, ions and neutrals and wall boundary condions.
@mrhardman mrhardman marked this pull request as ready for review May 29, 2024 08:37
@johnomotani johnomotani merged commit 3776e86 into master Jul 30, 2024
15 of 17 checks passed
@johnomotani johnomotani deleted the mms_bugfixes_and_docs branch July 30, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants